sirrobzeroone / comboblock

Stack some slabs.
Other
0 stars 2 forks source link

Server Crash #5

Closed Sumi1998 closed 2 years ago

Sumi1998 commented 3 years ago

I was excited to try this mod, however I get the following error:

ModError: Failed to load and run script from D:\Minetest\minetest-5.4.0-win64\bin..\mods\comboblock\init.lua: 2021-03-16 13:28:01: ERROR[Main]: ...etest-5.4.0-win64\bin..\builtin\common\misc_helpers.lua:481: bad argument #1 to 'pairs' (table expected, got string) 2021-03-16 13:28:01: ERROR[Main]: stack traceback: 2021-03-16 13:28:01: ERROR[Main]: [C]: in function 'pairs' 2021-03-16 13:28:01: ERROR[Main]: ...etest-5.4.0-win64\bin..\builtin\common\misc_helpers.lua:481: in function 'copy' 2021-03-16 13:28:01: ERROR[Main]: ...est\minetest-5.4.0-win64\bin..\mods\comboblock\init.lua:248: in main chunk 2021-03-16 13:28:01: ERROR[Main]: Check debug.txt for details. 2021-03-16 13:28:01: ACTION[Main]: Server: Shutting down

sirrobzeroone commented 2 years ago

Sorry just saw this issue, my guess is one of the other mods installed has the texture images as a string not a table. Which royal stuffs up comboblock. What block mod's did/do you have installed?

sirrobzeroone commented 2 years ago

Trying to dig into this issue the code failed at line 248 which is a little odd I would have expected a fail up around line 222 initailly if it was the tiles = "image_name.png" issue. I'm going to put a check in at both points to confirm the tiles are stored in a table.

sirrobzeroone commented 2 years ago

Worked the issue out, loop 2 is the 1st time we loop through all tiles/images hence the fail at 248 and not 222....unless you got super unlucky and the code happened to pick a very old slab to try and run first. I tried to locate some old doco on this issue but I can't find anything easily - cause is normally when someone has a slab/node def as tiles = "sometexture.png" instead of tiles = {"sometexture.png"}. I've adjusted the current code on repository to account for this scenario so when I do a release for MT 5.5 I'll close this issue.

sirrobzeroone commented 2 years ago

Fixed in https://github.com/sirrobzeroone/comboblock/releases/tag/5.5.0.1