search

sirxemic / jquery.ripples

Add a water ripple effect to your background using WebGL.
https://sirxemic.github.io/jquery.ripples/
MIT License
1.07k stars 418 forks source link

Using Ripple JS with Webpack #81

Open thatFemicode opened 3 years ago

thatFemicode commented 3 years ago

Good day, i was trying to use ripple JS with webpack some months back, and when going through the documentation it was not really specified how to use ripple JS with webpack, i would like to add the solution i found to your readme.md if you are comfortable with it as we are currently in the Hacktoberfest season in the developers community. Thanks and i look forward to your response.

sirxemic commented 3 years ago

Hi! I'm not sure if I understand correctly what you are talking about. Are you thinking of documenting that the user just has to do require('jquery.ripples') or import 'jquery.ripples' to use this when using bundlers? I guess it makes sense to cover that in the readme, however trivial it is. So I'm fine with you contributing that way, though I do then suggest to keep the language bundler-agnostic (maybe using Webpack as well as Rollup as examples).

thatFemicode commented 3 years ago

Okay thanks. Yes the user just imports or require jquery.ripples, it took me a while before I was able to get it to work as a beginner so I thought I’d had something beginner friendly or Junior dev friendly. I think all module bundlers work in a similar manner so I’d just keep import or require jquery.ripples after installation using npm or yarn. That’s alright Yhh? Sent from my iPhone

On Oct 3, 2021, at 10:23 PM, Pim Schreurs @.***> wrote:

Hi! I'm not sure if I understand correctly what you are talking about. Are you thinking of documenting that the user just has to do require('jquery.ripples') or import 'jquery.ripples' to use this when using bundlers? I guess it makes sense to cover that in the readme, however trivial it is. So I'm fine with you contributing that way, though I do then suggest to keep the language bundler-agnostic (maybe using Webpack as well as Rollup as examples).

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.