sisl / D3Trees.jl

Flexible interactive visualization for large trees in Julia using D3.js

Other

39 stars 7 forks source link

Added support for custom attributes in trees created via the AbstractTrees API #19

Closed ebalaban closed 5 years ago

codecov-io commented 6 years ago

Codecov Report

Merging #19 into master will decrease coverage by 6.26%. The diff coverage is 38.46%.

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
- Coverage   51.38%   45.12%   -6.27%     
==========================================
  Files           4        4              
  Lines          72       82      +10     
==========================================
  Hits           37       37              
- Misses         35       45      +10

Impacted Files	Coverage Δ
src/D3Trees.jl	`51.21% <38.46%> (-16.53%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4e93ac1...58c7e85. Read the comment docs.

coveralls commented 6 years ago

Coverage decreased (-49.7%) to 45.122% when pulling 58c7e8519d560b25dcefa10569920f41912059ec on abstract_trees_api into 4e93ac1ac6be93e850d36d553c4abb3d53a1da0d on master.

zsunberg commented 5 years ago

Thanks! Yeah, I think this is a good idea. I want to make a tweak or two before merging though. Will do that today or tomorrow.

ebalaban commented 5 years ago

Sure thing, thanks Zach. No rush. Also, perhaps a minor release can be done after the merge? This way people won't have to manually track 'master' to get this and a couple of preceding bug fixes/improvements.

On 12/4/2018 1:40 PM, Zachary Sunberg wrote:

Thanks! Yeah, I think this is a good idea. I want to make a tweak or two before merging though. Will do that today or tomorrow.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sisl/D3Trees.jl/pull/19#issuecomment-444269285, or mute the thread https://github.com/notifications/unsubscribe-auth/AM0QwEkFLlRSi2X1Tyeeo9PY9RYKuAitks5u1uvogaJpZM4Y8sqR.

zsunberg commented 5 years ago

Ok @ebalaban does this work for the purpose you had in mind. If it does, I'll merge it.

ebalaban commented 5 years ago

Yes, works very nicely. Thanks!

zsunberg commented 5 years ago

Cool. Thanks for the idea of improving the AbstractTrees interface