Testing on Windows

[zsunberg]

No one has made sure this works on windows yet - especially the inchrome function.

[mykelk]

It seems to display fine, but I do get these warnings:

WARNING: @functorize is deprecated as functor objects are no longer supported in julia
Stacktrace:
 [1] depwarn(::String, ::Symbol) at .\deprecated.jl:70
 [2] include_from_node1(::String) at .\loading.jl:569
 [3] include(::String) at .\sysimg.jl:14
 [4] include_from_node1(::String) at .\loading.jl:569
 [5] include(::String) at .\sysimg.jl:14
 [6] anonymous at .\<missing>:2
 [7] eval(::Module, ::Any) at .\boot.jl:235
 [8] process_options(::Base.JLOptions) at .\client.jl:286
 [9] _start() at .\client.jl:371
while loading C:\Users\Mykel\.julia\v0.6\Lazy\src\liblazy.jl, in expression starting on line 4
WARNING: @functorize is deprecated as functor objects are no longer supported in julia
Stacktrace:
 [1] depwarn(::String, ::Symbol) at .\deprecated.jl:70
 [2] include_from_node1(::String) at .\loading.jl:569
 [3] include(::String) at .\sysimg.jl:14
 [4] include_from_node1(::String) at .\loading.jl:569
 [5] include(::String) at .\sysimg.jl:14
 [6] anonymous at .\<missing>:2
 [7] eval(::Module, ::Any) at .\boot.jl:235
 [8] process_options(::Base.JLOptions) at .\client.jl:286
 [9] _start() at .\client.jl:371
while loading C:\Users\Mykel\.julia\v0.6\Lazy\src\liblazy.jl, in expression starting on line 4

WARNING: deprecated syntax "inner constructor Client(...) around C:\Users\Mykel\.julia\v0.6\HttpServer\src\HttpServer.jl:114".
Use "Client{T}(...) where T" instead.

WARNING: deprecated syntax "abstract Shell" at C:\Users\Mykel\.julia\v0.6\Blink\src\AtomShell/AtomShell.jl:6.
Use "abstract type Shell end" instead.
WARNING: using Lazy.remove in module AtomShell conflicts with an existing identifier.
WARNING: special characters "#{}()[]<>|&*?~;" should now be quoted in commands
Stacktrace:
 [1] depwarn(::String, ::Symbol) at .\deprecated.jl:70
 [2] warn_shell_special(::String) at .\shell.jl:8
 [3] #shell_parse#236(::String, ::Function, ::String, ::Bool) at .\shell.jl:103
 [4] (::Base.#kw##shell_parse)(::Array{Any,1}, ::Base.#shell_parse, ::String, ::Bool) at .\<missing>:0 (repeats 2 times)
 [5] @cmd(::ANY) at .\process.jl:796
 [6] include_from_node1(::String) at .\loading.jl:569
 [7] include(::String) at .\sysimg.jl:14
 [8] include_from_node1(::String) at .\loading.jl:569
 [9] include(::String) at .\sysimg.jl:14
 [10] include_from_node1(::String) at .\loading.jl:569
 [11] include(::String) at .\sysimg.jl:14
 [12] anonymous at .\<missing>:2
 [13] eval(::Module, ::Any) at .\boot.jl:235
 [14] process_options(::Base.JLOptions) at .\client.jl:286
 [15] _start() at .\client.jl:371
while loading C:\Users\Mykel\.julia\v0.6\Blink\src\AtomShell\process.jl, in expression starting on line 23

The command inchrome doesn't seem to work:

could not spawn `google-chrome 'C:\Users\Mykel\AppData\Local\Temp\jl_1D46.tmp\tree.html'`: no such file or directory (ENOENT)

Stacktrace:
 [1] _jl_spawn(::String, ::Array{String,1}, ::Ptr{Void}, ::Base.Process, ::RawFD, ::RawFD, ::RawFD) at .\process.jl:360
 [2] #375 at .\process.jl:512 [inlined]
 [3] setup_stdio(::Base.##375#376{Cmd}, ::Tuple{RawFD,RawFD,RawFD}) at .\process.jl:499
 [4] #spawn#374(::Nullable{Base.ProcessChain}, ::Function, ::Cmd, ::Tuple{RawFD,RawFD,RawFD}) at .\process.jl:511
 [5] run(::Cmd) at .\process.jl:650
 [6] inchrome(::D3Trees.D3Tree) at C:\Users\Mykel\.julia\v0.6\D3Trees\src\displays.jl:14
 [7] include_string(::String, ::String) at .\loading.jl:515

[zsunberg]

Thanks for the testing.

The @functorize warnings are from the Blink package I think.

If we want inchrome to work (I find it to be the easiest way to display the trees), someone needs to figure out what the command is to launch chrome in windows.

[mykelk]

It's start chrome "https://youtu.be/dQw4w9WgXcQ" for example.

[zsunberg]

inchrome should now work on windows. If someone could test it, that'd be great

[mykelk]

Fixed. And tested.