sismics / docs

Lightweight document management system packed with all the features you can expect from big expensive solutions
https://teedy.io
GNU General Public License v2.0
1.98k stars 489 forks source link

Specify document search parameter as HTTP params #722

Closed archiloque closed 1 year ago

archiloque commented 1 year ago

An implementation for https://github.com/sismics/docs/issues/720 , feedbacks are welcome.

I'm still doing some tests.

Notes so far:

I wonder if all the cases exposed through the "textual API" make sense for a programmatic one, for example:

What's your opinion ?

jendib commented 1 year ago

Looks good.

I agree that "at" and date formats other than "yyyy-MM-dd" could be removed to simplifiy. It should be the role of the caller to do those things with "before" and "after".

archiloque commented 1 year ago

@jendib thanks, I've updated the code accordingly

jendib commented 1 year ago

@archiloque Is this ready to merge?

archiloque commented 1 year ago

@jendib yes, I've done some integration tests and it seems to work