Closed archiloque closed 1 year ago
Looks good.
I agree that "at" and date formats other than "yyyy-MM-dd" could be removed to simplifiy. It should be the role of the caller to do those things with "before" and "after".
@jendib thanks, I've updated the code accordingly
@archiloque Is this ready to merge?
@jendib yes, I've done some integration tests and it seems to work
An implementation for https://github.com/sismics/docs/issues/720 , feedbacks are welcome.
I'm still doing some tests.
Notes so far:
docs-web/src/main/java/com/sismics/docs/rest/util/DocumentSearchCriteriaUtil.java
to avoid making a mess ofdocs-web/src/main/java/com/sismics/docs/rest/resource/DocumentResource.java
, at the end it's not too much new code.docs-web/src/main/java/com/sismics/docs/rest/util/TagUtil.java
fromdocs-core
because it was not used outside ofdocs-web
.get
andlist
for documents when generating the responses, as a consequence I added thefile_id
field to theget
response because it was missing there but was in thelist
one, which did not make sense.I wonder if all the cases exposed through the "textual API" make sense for a programmatic one, for example:
at
can be replaced bybefore
and anafter
, should it be available?yyyy-MM-dd
one should be enough?What's your opinion ?