sissa-data-science / DADApy

Distance-based Analysis of DAta-manifolds in python
https://dadapy.readthedocs.io/
Apache License 2.0
108 stars 18 forks source link

fix warnings related to float64-32 conversion #106

Closed AldoGl closed 11 months ago

AldoGl commented 11 months ago

Proposed changes

I fix two warnings.

The first appeared when a coordinate matrix of type float64 is passed to the Data constructor.

The second appeared as a consequence of the fact that the distance computation probably casts data to float32, and hence the correct precision to check for equal distances is the float32.

codecov-commenter commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (564df28) 80.22% compared to head (25ae557) 80.23%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #106 +/- ## ========================================== + Coverage 80.22% 80.23% +0.01% ========================================== Files 15 15 Lines 2432 2434 +2 ========================================== + Hits 1951 1953 +2 Misses 481 481 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

AldoGl commented 11 months ago

Thanks @vdeltatto!