search

sitespeedio / compare

Compare HAR files.
https://compare.sitespeed.io
MIT License
111 stars 18 forks source link

Result Page Not Refreshing Correctly after Changing HAR #151

Open monsuj opened 1 year ago

monsuj commented 1 year ago

Hi @soulgalore,

I found a minimal bug where result page is not refreshing correctly after changing Har file from result page upload button. Please find the description and steps to reproduce the same below.

Har Files Used and Description:

  1. BestBuy_En_Full_Har1.har : Full Home Page Capture of "https://www.bestbuy.ca/en-ca" including lazy loading till bottom of the page.
  2. BestBuy_En_Small_Har2.har : Home Page Capture of "https://www.bestbuy.ca/en-ca" but network recording stopped in the middle so it does not have all the requests.
  3. BestBuy_Ex_Small_Har3.har : Same Har as "BestBuy_En_Small_Har2.har but URL modified manually from "https://www.bestbuy.ca/en-ca" to "https://www.bestbuy.ca/ex-ca"

Steps to Reproduce Issue:

  1. Go to https://compare.sitespeed.io/
  2. Upload Har1 ("https://www.bestbuy.ca/en-ca") & Har3 (https://www.bestbuy.ca/ex-ca)
  3. It should not display the difference in http request as URLs are different. This is Expected.
  4. In the same page. Click on the upload button next to Har3 (https://www.bestbuy.ca/ex-ca)
  5. Upload BestBuy_En_Small_Har2.har
  6. This will generate the section "Request/response difference (larger than 1 kb)" as both the HAR files having same webpage i.e. https://www.bestbuy.ca/en-ca. This is expected
  7. In the same page. Click on the upload button next to Har2 (https://www.bestbuy.ca/en-ca)
  8. Upload BestBuy_Ex_Small_Har3.har
  9. Now 2 Har files are Har1 ("https://www.bestbuy.ca/en-ca") & Har3 (https://www.bestbuy.ca/ex-ca)
  10. So 2 different URLs so result page should refresh and it should display result same as Step 3
  11. But Section "Request/response difference (larger than 1 kb)" remains on the page. This in the issue

This seems like a minimal bug but if someone using this upload button option then they might report incorrect result due to this issue.

Attaching the Har files that I have used for testing.

HarFiles.zip

soulgalore commented 1 year ago

Thank you @monsuj for the very detailed bug report! I'll have look the coming and see if I can fix it.

monsuj commented 1 year ago

thanks @soulgalore