search

sixhours-team / memcached-spring-boot

Library that provides support for auto-configuration of Memcached cache in a Spring Boot application.
Apache License 2.0
71 stars 33 forks source link

Remove the private constructor of auto-configuration classes #129

Closed igorbolic closed 3 years ago

igorbolic commented 3 years ago

Hiding the public constructor from auto-configuration classes casuses the issue on application startup for Spring Boot version <= 2.1.x.

Removing the private constructor and letting the compiler to provide default no-arg constructor resolves the issue.

Resolves #128

codecov-commenter commented 3 years ago

Codecov Report

Merging #129 (1bd1114) into master (d7a6f09) will increase coverage by 0.06%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #129      +/-   ##
============================================
+ Coverage     90.77%   90.84%   +0.06%     
- Complexity      142      145       +3     
============================================
  Files            25       25              
  Lines           412      415       +3     
  Branches          8        8              
============================================
+ Hits            374      377       +3     
  Misses           24       24              
  Partials         14       14
Impacted Files Coverage Δ
...ache/AppEngineMemcachedCacheAutoConfiguration.java 60.00% <ø> (+10.00%) :arrow_up:
...ched/cache/SpyMemcachedCacheAutoConfiguration.java 60.00% <ø> (+10.00%) :arrow_up:
...cached/cache/XMemcachedCacheAutoConfiguration.java 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d7a6f09...1bd1114. Read the comment docs.