The Python IBM float packer is no longer provided as a plugin.

sixty-north / segpy

A Python package for reading and writing SEG Y files.

Other

102 stars 54 forks source link

The Python IBM float packer is no longer provided as a plugin. #86

Closed abingham closed 6 years ago

abingham commented 6 years ago

Instead, we only check if the C++ version is available as a plugin. If it's not (or if Python is explicitly requested) then we simply return a Python packer via normal means.

The main upshot is that you no longer need to install anything for tests to run.

coveralls commented 6 years ago

Coverage remained the same at 100.0% when pulling 6dc5b4ded0505babfdf33d6dc5bb1c5c3271b9d4 on abingham:do-not-require-entry-point-installation into e3e80d90e4917ccdcfbf8d38ee469ea0c0137890 on sixty-north:master.

abingham commented 6 years ago

Can we improve the efficiency a bit?

The short answer is yes, but I'm struggling a bit to find a way that maximizes efficiency (i.e. sets a global Packer based on configuration) while remaining completely testable.