search

sj26 / mailcatcher

Catches mail and serves it through a dream.
http://mailcatcher.me
MIT License
6.23k stars 571 forks source link

Drop legacy Ruby versions, including 3.0 #554

Closed tagliala closed 1 month ago

tagliala commented 5 months ago

3.0 will EOL soon, and it has issues when compiling eventmachine

Also:

Close #553

FinnIckler commented 5 months ago

While Mailcatcher starts now, assets are not served.

curl localhost:1080/assets/mailcatcher.js
<html>
<body>
  <h1>No Dice</h1>
  <p>The message you were looking for does not exist, or doesn't have content of this type.</p>
</body>
</html>
tagliala commented 5 months ago

Cannot replicate on my machine 🤔

$ curl localhost:1080/assets/mailcatcher.js
window.Modernizr=function(e,t,r){function n(e)...

command line:

BUNDLE_GEMFILE=~/dev/mailcatcher/Gemfile bundle exec ~/dev/mailcatcher/bin/mailcatcher -f -v --http-ip=0.0.0.0
FinnIckler commented 5 months ago

Here's a repro

docker run -it ruby:3.3.0 /bin/bash
# installing your gem
gem install specific_install && gem specific_install -l https://github.com/tagliala/mailcatcher.git -b feature/drop-legacy-ruby-versions
mailcatcher --http-ip=0.0.0.0 --no-quit
curl localhost:1080/assets/mailcatcher.js
FinnIckler commented 5 months ago

Ok, me and a colleague figured out that this is because the coffeescript files don't get compiled when installing the gem from this repo

tagliala commented 5 months ago

yes, the asset compile pipeline is quite outdated. It compiles on my machine but with several warnings :(

sj26 commented 1 month ago

Sorry for the delay, but this is wonderful, thank you.

ansonhoyt commented 1 month ago

Can confirm it's working with Ruby 3.3.0 (and Rails 7.1) after gem install mailcatcher --pre. Happy to have this nice tool working again, just in time to develop some new emails. 😅

Thanks all for the fix and release!