search

sjkingo / python-freshdesk

An API for the Freshdesk helpdesk
BSD 2-Clause "Simplified" License
87 stars 67 forks source link

Get all paginated data for list_comments() method #53

Closed jatzz10 closed 4 years ago

jatzz10 commented 4 years ago

Currently, the list_comments() method always retrieves only 30 results (comments at max.) per 'get' call even when the total no. of comments per ticket might exceeds 30. We need to add support for retrieving all of the paginated data for this.

sjkingo commented 4 years ago

The API docs show the list conversations/comments supports ?page= so we could implement similar to filter_tickets():

https://github.com/sjkingo/python-freshdesk/blob/master/freshdesk/v2/api.py#L169-L177

jatzz10 commented 4 years ago

Cool. Have raised a pull request for this here. Can you check? https://github.com/sjkingo/python-freshdesk/pull/54 Thanks!