Open blablahaha opened 5 years ago
@SmileYuhao I've got the same doubt. Have you tried other implementation (e.g., using previous prediction in loop_fn)?
@zxlmufc Yes, I tried another implementation, likes:
def _body(_current_time, _out_ta, *_state_queues):
current_input = _out_ta.read(_current_time)
next_input, updated_queues = _loop_fn(_current_time, current_input, _state_queues)
_out_ta = _out_ta.write(_current_time + 1, next_input)
return [_current_time + 1, _out_ta] + list(_state_queues)
But I didn't compare those two implementations. 🤣
@SmileYuhao I've compared both implementation on synthetic dataset. They are having similar performance. The new one, using previous predict, performed slightly better. In case you are curious.
@zxlmufc Coooool, thanks so much for satisfying my curiosity!
Hi,
Thanks so much for sharing your perfect work. But I was confused in the decode part:
https://github.com/sjvasquez/web-traffic-forecasting/blob/6cb4a91da94b85857ed637afb53a8d9594f7623c/cnn.py#L342-L349
In line 343, function
loop_fn
, always takesinitial_input
as the parametercurrent_input
.I wonder why we don't use previous prediction for
loop_fn
? Just likes: