skeletonlabs / floating-ui-svelte

A Floating UI wrapper for Svelte
https://floating-ui-svelte.vercel.app
MIT License
123 stars 4 forks source link

Chore: Cleanup `useRole` #94

Closed Hugos68 closed 1 month ago

Hugos68 commented 1 month ago

Linked Issue

Partially closes #53

Description

Adds missing tests and general code style. Also fixed a nasty bug in all interactions hooks that caused reactivity not to go through entirely

Changsets

We use Changesets to automatically create our changelog per each release. Any changes or additions to the Library assets in /lib must be documented with a new Changeset. This can be done as follows:

  1. Navigate to the root of the project on your feature branch.
  2. Run pnpm changeset to trigger the Changeset CLI.
  3. Follow the instructions when prompted.
    • Changesets should be either minor or patch. Never major.
    • Prefix your Changeset description using: feature:, chore: or bugfix:.
  4. Changeset .md files are added to the /.changeset directory.
  5. Commit and push the the new changeset file.

Checklist

Please read and apply all contribution requirements.

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
floating-ui-svelte ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 0:43am
endigo9740 commented 1 month ago

@Hugos68 make sure to delete old feature branches via the purple prompt near the bottom of this page. I'll let you take this one.