search

sketchfab / godot-plugin

MIT License
108 stars 20 forks source link

Download models #7

Closed RandomShaper closed 6 years ago

RandomShaper commented 6 years ago

With this one you can complete the flow of downloading, unpacking and importing.

Missing is the automatic opening of the imported scene. I'll submit that this afternoon.

Also this time you'll need another Godot executable, patched with a bugfix, that has already been submitted as a PR for official merging: https://github.com/godotengine/godot/pull/17607

Please give me some feedback ASAP.

RandomShaper commented 6 years ago

Added one more commit that let's you open the model.

Alas, you have to click the 3D tab manually to see it.

AurL commented 6 years ago

Thanks! I did some tests and it's working as expected.

Just a few comments: It seems that the "login" button is not working at the beginning, I was not able to log in with the button, but using Enter key works. For some reasons it's working after having be logged. Also, I get a few "Network operation failed. Try again later" popups, but I'm not sure where they come from. The console is printing this:

URI: /v3/search?count=24&cursor=24&downloadable=true&sort_by=-publishedAt&staffpicked=true&type=models
thirdparty\mbedtls\library\ssl_tls.c:3781: mbedtls_ssl_read_record_layer() returned -30848 (-0x7880)
thirdparty\mbedtls\library\ssl_tls.c:6932: mbedtls_ssl_read_record() returned -30848 (-0x7880)

(I might be related to the API returning bad data)

Also, depending on the asset, the import can freeze the software during a certain time before having the asset imported (I had the same issue with Unity. I don't know if it can be easily improved).

Anyway, the PR is ok I can merge. I will probably do more tests tomorrow.

RandomShaper commented 6 years ago

The freeze-while-importing issue is due to how that is done in Godot. Making it non-blocking would be very hard.