Open moros opened 1 month ago
Thank you.
Making an additional type public is a commitment of sorts that we'll try to not to make breaking changes to its API. So we'd prefer to minimize the public surface area of the module. Can you provide an example of something that can't be done via the existing Compose integration or a custom SwiftUI modifier?
The documentation under the Modifiers section seems to imply that its available for use outside of the skip-ui module. The composeModifier
as mentioned in the docs seems like it'll work for what I need currently. If I wanted to create my own SwiftUI view type and extend it accessing the context and view kind of like in the public onSubmit function in TextField then I would need access to the ComposeModifierView. Though this would probably be more of a rare occurrence.
Thank you for contributing to the Skip project! Please use this space to describe your change and add any labels (bug, enhancement, documentation, etc.) to help categorize your contribution.
Would be useful to make
ComposeModifierView
public to allow a 3rd party codebase to define their own view extensions. I was exploring creating my own extension as mentioned on the documentation but couldn't because of type visibility. The other types, like ComposeContext and ComposeResult are already public. I ran tests though I see existing failing cases; an @testable import makes internal types visible to the unit test meaning increasing the visibility more wouldn't contribute to test failers.Skip Pull Request Checklist:
swift test