skmp / reicast-emulator

Reicast was a multiplatform Sega Dreamcast emulator
https://reicast.emudev.org
Other
1.1k stars 346 forks source link

Old r7 release sprint #490

Closed skmp closed 6 years ago

skmp commented 10 years ago

The release is scheduled for FRIDAY, 17:00 GMT

r7-rc branch | Pending issues

This is a thread to coordinate testing, and see what's broken.

Keep in mind that

Irrelevant for r7 release window, but still worth to notice

First to Google play, perhaps staged deployment to check for major unexpected breakage, then to OUYA.

Let's get the ball rolling!

AbandonedCart commented 10 years ago

Has anyone confirmed the OSD not showing? As far as I could tell that was specific to one specific device

MrPsyMan commented 10 years ago

I can confirm that the OSD doesn't show up with the native interface enabled. It shows up with the native interface disabled.

This is on a rockchip based tablet I have here (a9 @1.6GHz with mali400, 1024x552 resolution, android 4.1.1, kernel 3.0.8).

AbandonedCart commented 10 years ago

I guess there needs to be some disclaimer that the native interface is for hardware controls only. The OSD gets overridden to support touchpads (which the touchscreen technically registers as)

MrPsyMan commented 10 years ago

Ah, so it's not meant to have the osd visible huh? Yeah, in that case it'd be better to have native mode off by default and note that enabling it disables the osd.

AbandonedCart commented 10 years ago

"Gamer mode - Disables unmotivated control schemes"

ptitSeb commented 10 years ago

I have compiled a version on Pandora. I don't have the Soul Calibur "Thin leg" issue on it. Crazy Taxi Pal is still broken.

AbandonedCart commented 10 years ago

I have a few minor fixes to test and I'll add in the new label for native mode. Things got crazy for the end of class rush. The only part that wasn't painful was building the profiler from Watch_Dogs as an android toy ;)

MrPsyMan commented 10 years ago

Found the regression that broke vs2 and ct.

All remaining now is to fix input for Shield and Moga mode B. But the related code is too complicated for me to touch without a chance of breaking it.

AbandonedCart commented 10 years ago

Nice work! I'm trying to get my head above water to do something about the controllers. I can try to start little by little but it may be ugly for a day or three.

MrPsyMan commented 10 years ago

Take your time. Drk plans to release no matter the state anyway, since we're already a lot behind schedule.

Also, the regression shouldn't happen. The commit I removed was doing what's supposed to. The bug is elsewhere, but was triggered when the our idle loop started working right. :p

hooby3dfx commented 10 years ago

action items from meeting:

  1. confirm if https://github.com/reicast/reicast-emulator/issues/521 is still an issue
  2. @LoungeKatt will make a post on forum about state of moga
  3. i will make an issue about bios selection and what is broken with it on kitkat (after @LoungeKatt merges pull request)
  4. i will verify default nvidia shield controls are what they should be
  5. prune list of icons on in game back menu
hooby3dfx commented 10 years ago

issues found/comments so far:

  1. bios copy issue in kitkat appears resolved, it just worked
  2. in game menu breaks when vmu screen is popped out
  3. vmu swap icon is used for both vmu and disc swap. can we just leave out disc swap for now? i suggest we hide back icon (since back button will close it anyway), disc swap, and debug menu.
  4. the dpad/analog stick issue default is now not joined
  5. shield controls seem good
AbandonedCart commented 10 years ago

@hooby3dfx Check the pull requests. Changes have been made for the icons and size of the menus.

hooby3dfx commented 10 years ago

ah - any reason not to merge it? @skmp do you approve of new icon?

On Sun, Oct 5, 2014 at 1:53 PM, TwistedUmbrella notifications@github.com wrote:

@hooby3dfx https://github.com/hooby3dfx Check the pull requests. Changes have been made for the icons and size of the menus.

— Reply to this email directly or view it on GitHub https://github.com/reicast/reicast-emulator/issues/490#issuecomment-57945877 .

hooby3dfx commented 10 years ago

@loungekatt the nested menus are still broken (last items get cutoff) and there is still an issue popping out the vmu.

On Sun, Oct 5, 2014 at 2:11 PM, Bryan Barnes hooby3d@gmail.com wrote:

ah - any reason not to merge it? @skmp do you approve of new icon?

On Sun, Oct 5, 2014 at 1:53 PM, TwistedUmbrella notifications@github.com wrote:

@hooby3dfx https://github.com/hooby3dfx Check the pull requests. Changes have been made for the icons and size of the menus.

— Reply to this email directly or view it on GitHub https://github.com/reicast/reicast-emulator/issues/490#issuecomment-57945877 .

AbandonedCart commented 10 years ago

@hooby3dfx I think you answered your own questions

AbandonedCart commented 10 years ago

The only issue I could reproduce with the VMU is at it pops out, but when popping it back in the other options are not shown until the menu is entered again.

I moved the right stick toggle to an actual preference, since it isn't something that will be needed in-game and removed the exit buttons. A device back button will exit the menu, but not take you to the previous one. The exit buttons were an overlap for not having to reopen the hidden immersive area. Back adds missing functionality.

skmp commented 10 years ago

I merged everything into master (woohoo bleeding edge :p). Gonna update the icon with a high(er) res one in a moment

AbandonedCart commented 10 years ago

Alright, I just tested the pull request I submitted a few minutes ago and it should resolve the sizing issues and more importantly, it doesn't break anything.

skmp commented 10 years ago

(FYI, if you do like, lounge/* branches (instead of your fork) they'll get tested by travis. That's why I have all my forks in here)

hooby3dfx commented 10 years ago

video of my issue with menu on shield: http://youtu.be/bkbxkqdaeSs

On Sun, Oct 5, 2014 at 4:34 PM, Stefanos Kornilios Mitsis Poiitidis < notifications@github.com> wrote:

(FYI, if you do like, lounge/* branches (instead of your fork) they'll get tested by travis)

— Reply to this email directly or view it on GitHub https://github.com/reicast/reicast-emulator/issues/490#issuecomment-57951191 .

skmp commented 10 years ago

20 full size png

AbandonedCart commented 10 years ago

Thanks, I'll have to move it over.

Give me two minutes and ill process all the resizes. The joys of Photoshop templates...

AbandonedCart commented 10 years ago

@hooby3dfx Clean your room :P

That is what I was getting. I think the menu cut-off is something with the layout params since it is still a smaller menu than the one that shows right before it without issue. I'll look at that while the icons are processing.

hooby3dfx commented 10 years ago

:smiley_cat: cool. guessing you have also seen the config menu but just in case: https://drive.google.com/file/d/0B3xeid6v2vUbRlZzWjZiZmpuUDg/view?usp=sharing

AbandonedCart commented 10 years ago

https://github.com/reicast/reicast-emulator/pull/542

AbandonedCart commented 10 years ago

@hooby3dfx The VMU will have to get pushed to r8, but at least it doesn't break any in-game functionality. I will look into it today. I lost internet shortly after my last IRC post, so I couldn't get anything done. Apparently getting the fastest connection they offer doesn't help reliability.

hooby3dfx commented 10 years ago

ok - i tested the latest build and the config menu was also getting cutoff issues. the icons were also tiny. do we know what changed with the code for the menu since r6?

On Mon, Oct 6, 2014 at 9:12 AM, TwistedUmbrella notifications@github.com wrote:

@hooby3dfx https://github.com/hooby3dfx The VMU will have to get pushed to r8, but at least it doesn't break any in-game functionality. I will look into it today. I lost internet shortly after my last IRC post, so I couldn't get anything done. Apparently getting the fastest connection they offer doesn't help reliability.

— Reply to this email directly or view it on GitHub https://github.com/reicast/reicast-emulator/issues/490#issuecomment-58014484 .

AbandonedCart commented 10 years ago

The whole menu changed. For r8 it will be an entirely different menu so if it cuts off now, there is no point even bothering with a fix.

hooby3dfx commented 10 years ago

gotcha - what did you have in mind for r8?

On Mon, Oct 6, 2014 at 10:26 AM, TwistedUmbrella notifications@github.com wrote:

The whole menu changed. For r8 it will be an entirely different menu so if it cuts off now, there is no point even bothering with a fix.

— Reply to this email directly or view it on GitHub https://github.com/reicast/reicast-emulator/issues/490#issuecomment-58024287 .

AbandonedCart commented 10 years ago

screenshot_2014-10-06-12-08-46

That is kinda rough, though. It can't be quite as transparent like the current one, but it'll actually have text labels.

skmp commented 10 years ago

from facebook

"HELP!!! I recently downloaded new reicast build and tested on my 3.5 inches phone the buttons are to very large on 2014-09-14 11:49:03 commit #aa33d23 apk build can you please fix this problem? this problem doesn't happen on r6(play store version) I'll test this build on 4 inches screen soon!!!"

https://fbcdn-sphotos-f-a.akamaihd.net/hphotos-ak-xap1/v/t1.0-9/10599596_1518243005088134_6170721758742937735_n.jpg?oh=bdbcc492c580fcd63537c38e60fcd54f&oe=54BBA13F&__gda__=1422685702_6daad8098f276fda3d5682534ba1f6d9

AbandonedCart commented 10 years ago

Too small for @hooby3dfx, too large for !!!! On FB haha. Feel like posting a 7.1 once I finish the menu? Not entirely sure how playing on a 3.5 is even enjoyable, though.

Also, you may want to change the rating on the listing to medium maturity. Stupid as it sounds, GP just sent me a formal warning over posting an app at low maturity because one of my preview images contained "depictions of violence" (one of the characters was holding a gun).

AbandonedCart commented 10 years ago

I should have something up by tonight. The advantage to switching to a vertical layout is that it is now wrapped in a ScrollView. That should resolve any issues with it being too large.

AbandonedCart commented 10 years ago

I went back and added the main menu as well, but right now it crashes when clicking the VMU. As soon as that is fixed, It will be all ready.

hooby3dfx commented 10 years ago

You da man

Sorry I can't help more, RL calls. I'm actually on vacation atm. On Oct 8, 2014 7:21 PM, "TwistedUmbrella" notifications@github.com wrote:

I went back and added the main menu as well, but right now it crashes when clicking the VMU. As soon as that is fixed, It will be all ready.

— Reply to this email directly or view it on GitHub https://github.com/reicast/reicast-emulator/issues/490#issuecomment-58443422 .

AbandonedCart commented 10 years ago

It's alright. I've got some family stuff going on but I figured I should jump on this while I had a minute.

http://www.youtube.com/watch?v=3LIpQfoaI8Y

I intend to line up to the icons though. Centered looks silly

AbandonedCart commented 10 years ago

http://youtu.be/QG-vEZ35CNY

Merged

hooby3dfx commented 10 years ago

xD ship it. Great job! On Oct 8, 2014 10:00 PM, "TwistedUmbrella" notifications@github.com wrote:

http://youtu.be/QG-vEZ35CNY

Merged

— Reply to this email directly or view it on GitHub https://github.com/reicast/reicast-emulator/issues/490#issuecomment-58454259 .

AbandonedCart commented 10 years ago

@skmp I did not forget you. Just finished and tested a basic BIOS locator. Adding it in a moment

skmp commented 10 years ago

Awww :D

skmp commented 10 years ago

From the mailbox

Hi there,

I'm currently using reicast on my jxd s7800b I'm using the newest build from the 5/10/2014 and I'm having problems with the input.

The emulator picks up my jxd but it doesn't recognise the L or r buttons, I then have to go in to inputs and manual set up the emulator but to get it working in the have to allow custom control layout, doing this allows the emulator to run with correct controls however one issue that there is, is that the emulator although correctly configured does not allow the L or R button to be multipressed.

For instance if I am playing crazy taxi r is used to accelerate L is to brake but if I press r to accelerate then let go and press L to brake nothing happens I then have to press L again for the action to be recognised, this also happens if I try to press r and L or any of the a, b, x, y, buttons in conjunction with the l or r triggers.

Just thought I would let you know.

Many thanks

Andrew

PS it also happens on some games if I used the thumbs ticks in conjunction with l or r triggers I.e. Incoming.

AbandonedCart commented 10 years ago

Not sure much can be done about that besides adding native support for the controller to see if L / R get picked up. If they don't work by default, they are not likely registering as axis values and have to go through the code to turn a button into an axis. It would be much easier turning an axis into a button, but that is Dreamcast for ya.

skmp commented 10 years ago

So, r7 depends on just #21, which is almost implemented in c2d1fbfdc2df5d5b31b38118fa399942d01443f9. Now only if new String(...) worked ...

skmp commented 10 years ago

Also, r7-rc should be merged to master (re-enables a bug that fixes some bugs)

skmp commented 9 years ago

Aalllriiightt, #614 and #615 seem to be the only ones left. I can tackle #615 within the next week, @LoungeKatt is #614 still relevant? Does the UI part work on all cases/android versions?

AbandonedCart commented 6 years ago

Archiving this since it is 3 years old and the issues it referenced were closed.