skodaconnect / homeassistant-myskoda

Homeassistant integration for MySkoda.
85 stars 14 forks source link

Lock colour should be green #225

Open paulwarwicker opened 2 weeks ago

paulwarwicker commented 2 weeks ago

Describe the bug The icon showing door state should be green. The unlocked door state is correctly shown as red.

**Is this working in MySkoda app?*** n/a

Latest working release New functionality

Debug logs n/a

Installation:

(venv) custom_components # python3 -m pip list Package Version


aiohappyeyeballs 2.4.3 aiohttp 3.10.10 aiomqtt 2.0.1 aiosignal 1.3.1 anyio 4.6.2.post1 arrow 1.3.0 asyncclick 8.1.7.2 asyncio 3.4.3 attrs 24.2.0 certifi 2024.8.30 charset-normalizer 3.4.0 coloredlogs 15.0.1 freezegun 1.5.1 frozenlist 1.5.0 humanfriendly 10.0 ics 0.7.2 idna 3.10 iniconfig 2.0.0 mashumaro 3.14 multidict 6.1.0 myskoda 0.8.9 orjson 3.10.11 packaging 24.1 paho-mqtt 1.6.1 pip 24.0 pluggy 1.5.0 propcache 0.2.0 Pygments 2.18.0 PyJWT 2.9.0 pytest 8.3.3 pytest_freezer 0.4.8 python-dateutil 2.9.0.post0 PyYAML 6.0.2 requests 2.32.3 six 1.16.0 sniffio 1.3.1 TatSu 5.12.1 termcolor 2.5.0 types-python-dateutil 2.9.0.20241003 typing_extensions 4.12.2 urllib3 2.2.3 yarl 1.17.1

Additional context image image

WebSpider commented 1 week ago

Thanks for the report!

WebSpider commented 1 week ago

It seems that your Door Lock is not active, the Lock button is not pressable. Have you filled in your S-PIN?

paulwarwicker commented 4 days ago

It seems that your Door Lock is not active, the Lock button is not pressable. Have you filled in your S-PIN?

i'm fairly sure it was because the unlocked state was showing red. maybe it wasn't at that time as i was swapping between beta versions. it is definitely set now and the UNLOCK is in HA blue image

i know you are not looking for like-for-like compatibility with the old integration but i think the icons shown here were all green in the old one image

paulwarwicker commented 4 days ago

btw this was from 1.9.1