search

skodaconnect / myskoda

Python library for interacting with MySkoda APIs.
MIT License
9 stars 22 forks source link

Remove ruff G004 exception #50

Closed WebSpider closed 1 month ago

WebSpider commented 1 month ago

Following some remarks this week about f-style and logging: Remove f-style strings from logging statements and disable G004 exception

dvx76 commented 1 month ago

Where was this discussed? I'm happy with consensus but I've never seen f-strings in log messages have any adverse impact. Is it an HA requirement?

WebSpider commented 1 month ago

On discord in #devs.. I looked it up and there indeed can be instances where logging and f-style can result in log messages getting eaten