skrafft / react-native-jitsi-meet

React native wrapper for Jitsi Meet SDK
Apache License 2.0
285 stars 349 forks source link

How to upgrade jitsi sdk in react-native-jitsi-meet #154

Open cloudoceansoft opened 4 years ago

cloudoceansoft commented 4 years ago

Hi @skrafft ,

Thanks a lot for providing such good exemple app. Just wanted to know if it is possible to upgrade jitsi sdk version as currently react-native-jitsi-meet is using 2.4.0 which doesn't support couple of features.

Can you please help me on it?

jfbourne commented 4 years ago

@cloudoceansoft

Option 1: If you are looking for the latest version 2.8.1 ios and 2.8.2 android, I forked this project and published my changes here https://github.com/jfbourne/react-native-jitsi-meet NOTE: I disabled some options for iOS and Android.. https://github.com/jfbourne/react-native-jitsi-meet/blob/master/ios/RNJitsiMeetViewManager.m#L47-L55 AND https://github.com/jfbourne/react-native-jitsi-meet/blob/master/android/src/main/java/com/reactnativejitsimeet/RNJitsiMeetModule.java#L60-L66

Option 2: On android, update file android/app/build.gradle with implementation ('org.jitsi.react:jitsi-meet-sdk:[YOUR VERSION HERE]') {... i.e implementation ('org.jitsi.react:jitsi-meet-sdk:2.8.2') {... and also update the android\build.gradle maven repository to maven { url "https://github.com/jitsi/jitsi-maven-repository/raw/master/releases" } then clean and build

On iOS go to ios\Podfile.lock and update - JitsiMeetSDK (2.8.1) and ` - react-native-jitsi-meet (2.1.1):

IMPORTANT: You might need to enable 'hermes' after upgrading for it to work on Android. See my replies below

jcihocki commented 4 years ago

@jfbourne

You had any luck with this on android out of curiosity? I tried bumping the version to 2.8.2 in my project and the app closes ~with no crash log and nothing logged to the JS console.~ due to a segfault. Possibly the crappy hardware I'm running on? I'm gonna start playing version roulette to see if I can get better behavior, but so far I've not looked at the release notes to see how incompatible the versions are.

On android, update file android/app/build.gradle with implementation ('org.jitsi.react:jitsi-meet-sdk:[YOUR VERSION HERE]') {... i.e implementation ('org.jitsi.react:jitsi-meet-sdk:2.8.2') {... and also update the android\build.gradle maven repository to maven { "https://github.com/jitsi/jitsi-maven-repository/raw/master/releases" } then clean and build

edit: segfaults on pixel 3 as well, so hardware not the issue.

ashirwad007786 commented 4 years ago

Option 1: If you are looking for the latest version 2.8.1 ios and 2.8.2 android, I forked this project and published my changes here https://github.com/jfbourne/react-native-jitsi-meet

@jfbourne With your repository, I'm receiving this error, when I try to start the app.

java.lang.UnsatisfiedLinkError: No implementation found for void org.webrtc.PeerConnectionFactory.nativeInitializeAndroidGlobals() (tried Java_org_webrtc_PeerConnectionFactory_nativeInitializeAndroidGlobals and Java_org_webrtc_PeerConnectionFactory_nativeInitializeAndroidGlobals__
lamualfa commented 4 years ago

@jfbourne Can you make new PR with the newer JITSI SDK?

antoinefotso commented 4 years ago

@jfbourne my app stop when I try to join conference after update, It have other things to do apart what u mentioned above?

jfbourne commented 4 years ago

@jcihocki Try enabling hermes project.ext.react = [ entryFile: "index.js", enableHermes: true // clean and rebuild if changing ] and excluding it from implementation ('org.jitsi.react:jitsi-meet-sdk:2.8.2') { exclude group: 'com.facebook',module:'hermes' transitive = true }

jfbourne commented 4 years ago

@ashirwad007786 are you doing a custom build? I believe I only ran into that issue with a custom build or if I tried ver 2.8.0. Try option 2 as I described above instead of my repository and see if that works

jfbourne commented 4 years ago

@antoinefotso is this in both iOS and Android? I only noticed this on android and enabling hermes and excluding it from implementation of jitsi worked for me. see my reply to @jcihocki

jcihocki commented 4 years ago

@jcihocki Try enabling hermes project.ext.react = [ entryFile: "index.js", enableHermes: true // clean and rebuild if changing ] and excluding it from implementation ('org.jitsi.react:jitsi-meet-sdk:2.8.2') { exclude group: 'com.facebook',module:'hermes' transitive = true }

Thanks, I'll give this a shot at some point. I ended up going a different direction to get my app working with up to date jitsi but it was painful and could benefit from reverting that.

jfbourne commented 4 years ago

@jcihocki sorry it took me a while to reply, I was quite busy with my day job. Hopefully this works

Mayank8290 commented 4 years ago

blank screen in the android first time and then the second time it start the conference.

sunilkumarjena21 commented 3 years ago

Hi @jfbourne Thanks for your awesome support on this community.

I have followed the step build my own SDK as mentioned in the below link.

Branch builds fine:-https://github.com/jitsi/jitsi-meet/tree/mobile-fix-20.5-build

// Jitsi Meet implementation('org.jitsi.react:jitsi-meet-sdk:2.11.0')

Wanted to achieve the customization as per below:- Trying to change jitsi-meet-sdk to connect-lane-sdk

Step followed:- Step 1:-Changed the below lines in build.gradle of SDK Step -2: npm i Step -3:./android/scripts/release-sdk.sh /tmp/repo Step-4:-Uploaded in my repo:https://github.com/sunilkumarjena21/connectlane-android-sdk Step 5:- Used in my android project implementation('org.connect.react:connect-lane-sdk:2.11.0')

Got the below error as mentioned in below screenshot. sdk-img

You help will be much appreciated on this. Thanks in advance!

keremoge commented 3 years ago

hi, Any proper upgrade for jitsi-meet-sdk version 3.+ ?

rcidt commented 3 years ago

hi, Any proper upgrade for jitsi-meet-sdk version 3.+ ?

Interested in this as well