standardise on UTF-8 when converting strings to/from bytes

sksamuel / avro4s

Avro schema generation and serialization / deserialization for Scala

Apache License 2.0

719 stars 237 forks source link

standardise on UTF-8 when converting strings to/from bytes #839

Closed pjfanning closed 4 months ago

pjfanning commented 4 months ago

issue is that if you don't specify the charset, the default is machine specific

pjfanning commented 4 months ago

Apologies, the code didn't compile in Java 8. I was testing locally with a newer Java version. I have added a commit that I think should fix the compile issues.

sksamuel commented 4 months ago

lgtm