search

sksamuel / hoplite

A boilerplate-free Kotlin config library for loading configuration files as data classes
Apache License 2.0
923 stars 74 forks source link

Kotlin AWS sdk #424

Open samu-developments opened 4 months ago

samu-developments commented 4 months ago

We had a use case similar to this https://github.com/aws/aws-sdk-java-v2/issues/4501#issuecomment-1774988695; testing with Localstack and overriding AWS sdk endpoints using env variables. This is for some reason not supported in Java sdks, but it is in Kotlin sdks.

This PR is a copy of the hoplite-aws module, with java aws sdk switched with kotlin sdk. Also updated kotlin version and updated some usage of version catalogs, gradle.

I will have this as draft until this has feedback

Kotlin version needed to be updated for the newest Kotlin aws sdk to be compatible > The binary version of its metadata is 1.9.0, expected version is 1.6.0. Also fixed kotlin test tasks needing jdk 11 (required by testcontainers). > Inconsistent JVM-target compatibility detected for tasks 'compileTestJava' (11) and 'compileTestKotlin' (1.8).

sarahzargari commented 1 month ago

@sksamuel any updates on when this might move past draft status?

samu-developments commented 1 month ago

I can take a look at it next week again

samu-developments commented 1 month ago

Look at that, now the java sdk contains the env variable endpoint override. Anyway I rebased the branch and will make it ready for review.