skunkforce / OmniView

This Repository contains the OmniView Software, which is used in the AW4null Research Projects
https://www.autowerkstatt40.org/
MIT License
3 stars 4 forks source link

saving process and progress bar #154

Closed R-Abbasi closed 2 weeks ago

R-Abbasi commented 2 weeks ago

Here's a test for a half an hour measurement with more than180 million y values. It took 9 seconds for saving on my machine:

Untitled

NP199 commented 2 weeks ago

I have two issue. When the Popup is opened, the width of the popup is my main window width and not entirely visible anymore. Screenshot WindowSize

And the csv file format is not correct. This is not an valid .csv file format.

Screenshot CSVFile

R-Abbasi commented 2 weeks ago

The first case belongs to this line and should be fine. Here's a quick test on my machine: 2

The second case is a remedy to fix an issue for which there's already a link in the description.

NP199 commented 2 weeks ago

@R-Abbasi please check if gcc 13 compiles your features. Then we can use this workflow fix https://github.com/skunkforce/OmniView/tree/np/GCCTest

In there is an update to the gcc version 13 for Ubuntu, this could help building the new c++23 features.

R-Abbasi commented 2 weeks ago

That's good news. Sure it works with gcc 13.

NP199 commented 2 weeks ago

https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2204-Readme.md Here different software version which can be used. The beta Ubuntu2404 version could be used for gcc version 14. https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2404-Readme.md But i think we should wait for the release version

R-Abbasi commented 2 weeks ago

I suggest that we go for GCC 13 for now, as it works, and use the resize_and_overwrite API. We may consider using <print> later on when there's a CI runner on GitHub for GCC 14. Do you agree, please?

NP199 commented 2 weeks ago

I agree

AKMaily commented 2 weeks ago

The .csv file needs to be in a valid format. This includes 1. new lines between the different data points 2. a header where the metadata is saved in only one line

R-Abbasi commented 2 weeks ago

As for 2, what do you mean by that metadata, please? We now have string literals of the input text fields on the first line, device type on the second, device serial on the third and sampling rate on the fourth. Do you mean to have these all on one line, please?

AKMaily commented 2 weeks ago

As for 2, what do you mean by that metadata, please? We now have string literals of the input text fields on the first line, device type on the second, device serial on the third and sampling rate on the fourth. Do you mean to have these all on one line, please?

yes they should be all in one line, seperated by a comma