skupperproject / skupper

Skupper is an implementation of a Virtual Application Network, enabling rich hybrid cloud communication.
http://skupper.io
Apache License 2.0
597 stars 75 forks source link

V2 Default values for listener and connector commands #1663

Closed lynnemorrison closed 2 months ago

lynnemorrison commented 2 months ago

Default routing-key in listener and connector commands Default selector in connector command

if routing-key flag is not set then set the routing-key to equal the name of the listener or connector. If selector, host or workload are not set in the connector command default to selector to equal "app=connector-name".

nluaces commented 2 months ago

If selector, host or workload are not set in the connector command default to selector to equal "app=".

Do you mean "app=connector-name", right?

lynnemorrison commented 2 months ago

@nluaces listener host is also defaulted to listener-name. Do you still want it in the command in the README? skupper listener create backend 8080 -n west vs skupper listener create backend 8080 --host backend -n west

nluaces commented 2 months ago

Oh, sure, you are right, it is better skupper listener create backend 8080 -n west