skyplane-project / skyplane

🔥 Blazing fast bulk data transfers between any cloud 🔥
https://skyplane.org
Apache License 2.0
999 stars 58 forks source link

[bug] AWS: deprovision --all does not deprovision all resources in AWS #921

Open jpo-tu opened 11 months ago

jpo-tu commented 11 months ago

Describe the bug The deprovision --all command does not deprovision all resources in AWS.

To Reproduce

  1. initiate a copy or sync from any cloud provider to AWS; this provisions a VPC and ancillary resources in AWS
  2. deprovision everything:
    skyplane deprovision --all

Expected behavior All resources created by skyplane in AWS - that is, EC2 instances, instance profiles, security groups, route table associations, VPC endpoints, nacls, subnets, internet gateways, VPCs - should be deleted.

Actual behavior Only EC2 instance profiles are deleted. EC2 instances themselves are typically already terminated at the end of a copy/sync.

Output:

root@28e526f36e9b:/workdir# skyplane deprovision --all
No instances to deprovision
✓ Removing IPs from VPCs (1/1) in 1.95s
Deleting firewall rule: allow-default-4db23ad1
Deleting firewall rule: allow-default-9bb0b9df
Deleting firewall rule: skyplane-default-allow-icmp
Deleting firewall rule: skyplane-default-allow-internal
Deleting firewall rule: skyplane-default-allow-ssh

Environment info:

Additional context Why isn't delete_vpc invoked when deprovisioning in AWS?