search

skywardmc / additive

Simple and fast open-source OptiFine alternative for modern loaders
https://additive.intergrav.xyz/
MIT License
74 stars 10 forks source link

"Play World", "Share World", "Create World" button names are empty in the German localization #64

Closed marlester-dev closed 4 months ago

marlester-dev commented 4 months ago

Describe the bug In the singe-player worlds menu these 3 buttons don't have names when the German language is chosen.

To Reproduce Steps to reproduce the behavior:

  1. Go to Languages and choose German
  2. Go to the singleplayer menu
  3. Look at the buttons
  4. See the bug

Expected behavior Buttons should have their German names.

Screenshots When English is chosen: en When German is chosen: de

Device info (please complete the following information):

Additional context Modpack version - 1.25.1+1.20.4.fabric

marlester-dev commented 4 months ago

This problem also seems to appear in Spanish and a few other languages.

intergrav commented 4 months ago

Thanks, will be looking into this. Could you try disabling the Loqui mod and see if that fixes it?

marlester-dev commented 4 months ago

Thanks, will be looking into this. Could you try disabling the Loqui mod and see if that fixes it?

Without Loqui, the buttons seem to have text, yet not a german one, but an english one: noloq

Gaming32 commented 4 months ago

Base World Host does not have German translations for these buttons, so the game falls back to English.

marlester-dev commented 4 months ago

Base World Host does not have German translations for these buttons, so the game falls back to English.

Yeah, so I opened a pull request with German translations on World Host Github page. It will fix the problem.

marlester-dev commented 4 months ago

But why does it not automatically fall back when loqui is installed? Like why empty buttons

Gaming32 commented 4 months ago

It appears that any untranslated strings are blank in Loqui. My guess is that these strings are uploaded to Lokalise as blank to indicate they need translation. However blank (meaning untranslated) isn't checked when downloading these translation files back from Lokalise, leading to this issue. This is a bug with Loqui and a bug report should be made on its issue tracker.

Gaming32 commented 4 months ago

Loqui has fixed this. Here's the message from their Discord:

@News Pings @Translator Pings

Loqui Empty Strings Fixed

The bug with empty strings being downloaded has been fixed on the API - it may take 10-20 minutes for my changes to apply globally, after this 10-20 minutes, you should delete your .loqui_translations folder in .minecraft if you are affected. Thank you for your patience.

If you're wanting to translate, please help us out here: https://loqui.imb11.dev/