Open olleolleolle opened 4 months ago
1 Warning | |
---|---|
:warning: | There're library changes, but not tests. That's OK as long as you're refactoring existing code. |
Generated by :no_entry_sign: Danger
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
spec/slack/real_time/concurrency/clients/async_spec.rb | 1 | 87.5% | ||
spec/slack/real_time/concurrency/with_concurrency_spec.rb | 1 | 80.0% | ||
lib/slack/real_time/concurrency/async.rb | 28 | 1.39% | ||
<!-- | Total: | 30 | --> |
Totals | |
---|---|
Change from base Build 7789505062: | -0.08% |
Covered Lines: | 5092 |
Relevant Lines: | 5711 |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
spec/slack/real_time/concurrency/clients/async_spec.rb | 1 | 87.5% | ||
spec/slack/real_time/concurrency/with_concurrency_spec.rb | 1 | 80.0% | ||
lib/slack/real_time/concurrency/async.rb | 28 | 1.39% | ||
<!-- | Total: | 30 | --> |
Totals | |
---|---|
Change from base Build 7789505062: | 0.002% |
Covered Lines: | 5100 |
Relevant Lines: | 5715 |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
lib/slack/real_time/concurrency/async.rb | 28 | 1.39% | ||
<!-- | Total: | 28 | --> |
Totals | |
---|---|
Change from base Build 7789505062: | -0.08% |
Covered Lines: | 5092 |
Relevant Lines: | 5711 |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
lib/slack/real_time/concurrency/async.rb | 28 | 1.39% | ||
<!-- | Total: | 28 | --> |
Totals | |
---|---|
Change from base Build 7789505062: | 0.002% |
Covered Lines: | 5100 |
Relevant Lines: | 5715 |
Totals | |
---|---|
Change from base Build 7789505062: | -0.08% |
Covered Lines: | 5092 |
Relevant Lines: | 5711 |
Totals | |
---|---|
Change from base Build 7789505062: | 0.002% |
Covered Lines: | 5100 |
Relevant Lines: | 5715 |
Totals | |
---|---|
Change from base Build 7789505062: | -0.08% |
Covered Lines: | 5092 |
Relevant Lines: | 5711 |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
lib/slack/real_time/concurrency/async.rb | 28 | 1.39% | ||
<!-- | Total: | 28 | --> |
Totals | |
---|---|
Change from base Build 7789505062: | -0.08% |
Covered Lines: | 5092 |
Relevant Lines: | 5711 |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
lib/slack/real_time/concurrency/async.rb | 28 | 1.39% | ||
<!-- | Total: | 28 | --> |
Totals | |
---|---|
Change from base Build 7789505062: | -0.08% |
Covered Lines: | 5092 |
Relevant Lines: | 5711 |
Totals | |
---|---|
Change from base Build 7789505062: | 0.002% |
Covered Lines: | 5100 |
Relevant Lines: | 5715 |
Totals | |
---|---|
Change from base Build 7789505062: | 0.002% |
Covered Lines: | 5100 |
Relevant Lines: | 5715 |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
lib/slack/real_time/concurrency/async.rb | 28 | 1.39% | ||
<!-- | Total: | 28 | --> |
Totals | |
---|---|
Change from base Build 7789505062: | 0.002% |
Covered Lines: | 5100 |
Relevant Lines: | 5715 |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
spec/slack/real_time/concurrency/clients/async_spec.rb | 1 | 87.5% | ||
spec/slack/real_time/concurrency/with_concurrency_spec.rb | 1 | 80.0% | ||
lib/slack/real_time/concurrency/async.rb | 28 | 1.39% | ||
<!-- | Total: | 30 | --> |
Totals | |
---|---|
Change from base Build 7789505062: | -0.08% |
Covered Lines: | 5092 |
Relevant Lines: | 5711 |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
spec/slack/real_time/concurrency/clients/async_spec.rb | 1 | 87.5% | ||
spec/slack/real_time/concurrency/with_concurrency_spec.rb | 1 | 80.0% | ||
lib/slack/real_time/concurrency/async.rb | 28 | 1.39% | ||
<!-- | Total: | 30 | --> |
Totals | |
---|---|
Change from base Build 7789505062: | -0.08% |
Covered Lines: | 5092 |
Relevant Lines: | 5711 |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
spec/slack/real_time/concurrency/clients/async_spec.rb | 1 | 87.5% | ||
spec/slack/real_time/concurrency/with_concurrency_spec.rb | 1 | 80.0% | ||
lib/slack/real_time/concurrency/async.rb | 28 | 1.39% | ||
<!-- | Total: | 30 | --> |
Totals | |
---|---|
Change from base Build 7789505062: | 0.002% |
Covered Lines: | 5100 |
Relevant Lines: | 5715 |
If you don't .rewind
you end up with incorrect data, don't you? I think we need an integration test for the various servers at the very least before changing this.
Coveralls is being annoying re-running on every commit... maybe you know how to turn this off?
This PR is an experiment to make slack-ruby-client able to be used with Webrick via rackup gem.
The "rewind-read-rewind" used here:
https://github.com/slack-ruby/slack-ruby-client/blob/9e6d1171aecfb89d11ce55fb010cc3370666cd01/lib/slack/events/request.rb#L39-L47
...is no longer supported.
This change is about making the code compatible with older servers that offered rewind.