search

slaclab / lume-genesis

Genesis 1.3 tools for use in LUME
https://slaclab.github.io/lume-genesis/
Apache License 2.0
4 stars 7 forks source link

`write_namelists` `make_namelist_symlinks` is defunct #19

Open ken-lauer opened 5 months ago

ken-lauer commented 5 months ago

Issue

https://github.com/slaclab/lume-genesis/blob/2125b334fd70cc82e478cc6fecfa4dae29ae8666/genesis/version4/writers.py#L171-L173

make_namelist_symlinks is not defined in lume-genesis GitHub reveals that it is available here: https://github.com/ChristopherMayes/lume-astra/blob/459b5e8bab72d8871ae971cca8c48da1ce5bc389/astra/writers.py#L49C5-L49C5

Was this feature not used?

(Discovered while looking into #18 )

ChristopherMayes commented 5 months ago

Oh, that's probably copy-paste that I never tested. This feature was thought to be important if files got to be too big.