search

slages / love-imgui

imgui module for the LÖVE game engine
MIT License
321 stars 61 forks source link

love 0.11 support #15

Closed shakesoda closed 6 years ago

shakesoda commented 7 years ago

the module doesn't work at all with love 0.11, it just errors out when you try to do anything.

I don't know what your policy on supporting pre-release builds is, but AFAIK the rendering-related stuff for 0.11 is pretty stable now.

slages commented 7 years ago

Last time I tested it worked, not sure what's going wrong now... But I'll probably wait for it to be released before supporting it officialy.

qoh commented 7 years ago

I have managed to get the demo in the README working fine with LÖVE 0.11.0 (7782351), in the minor branch of my fork. These were the changes I made.

qoh commented 7 years ago

It looks like the main reason some of the errors were so mysterious is that Lua chunk calls failed, and just left errors on the stack that were never handled, instead of the results it was expecting to work on. It would be highly beneficial to actually check for these.

slages commented 7 years ago

Great I'll try to integrate it when I'll find some time, ideally by keeping the compatibility with love 0.10.* versions.

oniietzschan commented 6 years ago

Now that Love 11.0 is officially out, hopefully someone can take a look at this some time soon.

Short of fixing this on master, if @qoh or someone else could upload imgui.dll from @qoh's fork, that would be greatly appreciated. I tried to build the *.dll a couple months ago, but I have no experience building software for Windows and was not able to figure out how to get it to compile.

shakesoda commented 6 years ago

@oniietzschan here's my build of it from a while back, should still work: imgui.zip

radgeRayden commented 6 years ago

Any update on this? I'm on linux so I can't use the dll.

slages commented 6 years ago

I've updated the repo to use LOVE 11.1, and I'll soon prepare a release and make the pre-built binaries.