search

slamdata / purescript-quasar

Quasar API library for PureScript
Apache License 2.0
1 stars 7 forks source link

SD 2068 - add header config to CSV toMediaType #63

Closed Cmdv closed 7 years ago

Cmdv commented 7 years ago

this fixes https://github.com/slamdata/slamdata/issues/2068

Cmdv commented 7 years ago

Ah ok, I just changed it to match bellow which was in last comment here:

application/zip,text/csv;columnDelimiter=",";rowDelimiter="\n";quoteChar="";escapeChar="";disposition="attachment;filename*=UTF-8''mytest.zip"

but did feel weird to leave some values as empty string!! should of put WIP as not tested it yet 😄

Cmdv commented 7 years ago

@garyb ah ok, do you mean something like this:

"columnDelimiter=\"" <> opts.columnDelimiter <> "\""

Cmdv commented 7 years ago

@garyb ready for review 😄