search

slamdata / purescript-quasar

Quasar API library for PureScript
Apache License 2.0
1 stars 7 forks source link

Renaming Mimir to Local #68

Closed Cmdv closed 7 years ago

Cmdv commented 7 years ago

as per https://github.com/slamdata/slamdata/pull/2212 renaming Mimir to Local

garyb commented 7 years ago

I don't think we need to change anything here, it's only the label in the dropdown in the frontend that should change.

kritzcreek commented 7 years ago

But why have the disconnect between code and domain?

Cmdv commented 7 years ago

@garyb edit: what he said ☝️ hehe

garyb commented 7 years ago

@kRITZCREEK there's always going to be a mismatch somewhere, since it's still Mimir everywhere we interact with Quasar itself :wink:

kritzcreek commented 7 years ago

Oh I see. So we're going to continue calling it mimir everywhere but in the UI? That's a little confusing... But thanks for the clarification!

Cmdv commented 7 years ago

why not ask quasar folk to change it to Local so we have it through out?

edit: seems the choice of name is potentially temporary ¯\_(ツ)_/¯ https://github.com/slamdata/slamdata/issues/2071#issuecomment-325151401

Cmdv commented 7 years ago

what is the consensus then we just renaming it in the dropdown or going through out?

garyb commented 7 years ago

@kRITZCREEK I don't know, but if we want this to work with Quasar as it stands the mount type & key is called "mimir" and I haven't seen anything to suggest it'll be renamed? If that's changing too, then yeah it definitely makes sense to update the naming internally.

@Cmdv that's talking about the name of the mount in the VFS, like there'll be a /local/... mounted automatically.

Cmdv commented 7 years ago

@garyb well I linked above where it was agreed for a rename of local on frontend but haven't a clue about the VFS or anywhere else. It's all pretty vague and doesn't seem set in stone. I'll close this then just rename in drop down until there is more clarity on what is actually happening 😄

garyb commented 7 years ago

@Cmdv what I'm saying is that reply isn't about renaming anything, it's saying "when we add the prebaked mount, call it /local" :wink:

The VFS means the filesystem you see via the frontend, as opposed to the actual (physical) filesystem.

Cmdv commented 7 years ago

but it's also going to be called local in the dropdown so kind of confused, there should have been more clarity that's all I'm saying 😉