search

slapperwan / gh4a

Github client for Android
Apache License 2.0
1.73k stars 221 forks source link

search icon #307

Closed Sohalt closed 8 years ago

Sohalt commented 8 years ago

I'd like to propose to move the repo search from the menu on the left to a looking glass icon in the top bar, as this seems to be the ui guideline standard for search. Additionally search is such a common operation that having to open the menu first each time is a little cumbersome.

maniac103 commented 8 years ago

I don't want to this for a reason: the search isn't related to the contents of the main view, e.g. the event list. Users might (rightfully) expect the search would return event list results if it was in the top bar, which isn't the case. The search icon already is in the top bar in cases where it makes sense, e.g. in the issue list.

Sohalt commented 8 years ago

Understandable. Maybe adding the explore repos as a new tab and having search there search repos and search in the event stream search events might be an option?

maniac103 commented 8 years ago

One can't search events (the API doesn't allow it), and the next version won't have any tabs in the main view ;)

Sohalt commented 8 years ago

OK. Then I'll best wait for the next version and see if I can come up with a better idea for search. You can close this. (I would do it myself but the app doesn't allow me to… gotta make an issue for that :D)

maniac103 commented 8 years ago

It should allow you to close though: https://github.com/slapperwan/gh4a/blob/master/src/com/gh4a/activities/IssueActivity.java#L329

Sohalt commented 8 years ago

Hmmm, could it be that I need a phone with a dedicated menu button for this? I only have the back arrow at the top left and the share icon at the top right. And a text entry at the bottom for comments.

maniac103 commented 8 years ago

There should be a button labelled 'close' left to the share button.

Sohalt commented 8 years ago

It's not there for me. (Using v3.8.1 from fdroid)

maniac103 commented 8 years ago

Might it be possible you logged in with Octodroid with 'sohalt' as user name (or any other capitalization difference)?

Sohalt commented 8 years ago

Ehm, right. All lower caps.

Sohalt commented 8 years ago

OK, logging in with the right capitalization shows the close button. Should maybe be documented somewhere or fixed to work with any case.

maniac103 commented 8 years ago

The capitalization thing is probably worth its own bug report though. If Githib doesn't care about the capitalization on login, we shouldn't care either.

Sohalt commented 8 years ago

I opened a separate issue.