search

slashmo / gsoc-swift-tracing

WIP collection of Swift libraries enabling Tracing on Swift (Server) systems.
https://summerofcode.withgoogle.com/projects/#6092707967008768
Apache License 2.0
20 stars 1 forks source link

Correctly forward channel events in NIO instrumentation handlers #152

Closed slashmo closed 4 years ago

slashmo commented 4 years ago

Due to early-exit in a guard-statement in both NIO instrumentation handlers, I missed forwarding read/write events to chained handlers. This has been fixed and regression-tested now.

I also renamed both handlers to include Server/Client to indicate their purpose more clearly.

ktoso commented 4 years ago

Feel free to merge :) sorry I'm slow on reviews this week