search

sleuthkit / autopsy

Autopsy® is a digital forensics platform and graphical interface to The Sleuth Kit® and other digital forensics tools. It can be used by law enforcement, military, and corporate examiners to investigate what happened on a computer. You can even use it to recover photos from your camera's memory card.
http://www.sleuthkit.org/autopsy/
2.44k stars 595 forks source link

The nbexec script must be fixed for macOS #5804

Open Lazza opened 4 years ago

Lazza commented 4 years ago

Currently, the platform/lib/nbexec script contains the following at line 161:

jdkhome=`/usr/libexec/java_home --version 1.8.0+ --failfast`

However, this does not detect the Liberica JDK 8 package correctly. This should be written instead:

jdkhome=`/usr/libexec/java_home --version 1.8 --failfast`

This also conforms to the instructions written in Running_Linux_OSX.txt. If the nbexec script is fixed, the JAVA_HOME must only be set once for the UNIX setup step. After that, it does not even need to be set correctly.

markmckinnon commented 4 years ago

This file is part of the Netbeans platform that Autopsy uses. It is not part of Autopsy.

Lazza commented 4 years ago

@markmckinnon thank you for your reply.

I see... Is there any kind of build script that I can check to see if the substitution of this string can be automated?

It is very important on macOS if the user has more than one JDK installed, because setting the JAVA_HOME doesn't help.

markmckinnon commented 4 years ago

The files are part of the build process so there is no way to automate changing that file that I am aware of.

Lazza commented 4 years ago

Thank you. I see that there are some scripts in /release_scripts that maybe are run after the releases are built... like a kind of "post build hook".

IMHO, if there is such a mechanism, it should be possible to use it to fix the nbexec command as well. Unfortunately I know very little about the code base.