slim-template / ruby-slim.tmbundle

A Textmate / Sublime Text bundle for Slim
http://slim-lang.com/
MIT License
184 stars 46 forks source link

Comments not being greyed out. #74

Closed unmultimedio closed 7 years ago

unmultimedio commented 7 years ago

When comments are indented at same level, without a space from last line of code, it doesn't gets greyed out if slim has ruby code.

slim-comment

tshedor commented 7 years ago

@unmultimedio Are you still seeing this with the release of ST3? I've tried to duplicate in 3143 and it's highlighting properly

unmultimedio commented 7 years ago

Actually @tshedor I'm using Atom. Theres this repo who uses this to generate automatically a language package from this build: https://github.com/IanMitchell/slim-language

fluke commented 7 years ago

screen shot 2017-09-16 at 3 07 25 pm

Getting this after upgrading to the latest Sublime build. If I use a slash inside Ruby it messes up the commenting.

tshedor commented 7 years ago

@unmultimedio Ah, I see. I can't speak to how they're compiling this repo, and the README/referenced issue says it's being compiled from a different fork. I'm going to consider this closed here but leave it open the issue you opened on the official Atom package - slim-template/language-slim#26. I plan to jump into that code soon.

tshedor commented 7 years ago

@kartikluke This is actually parsing correctly in Slim but not in the Ruby syntax definition that Sublime comes with. sublimehq/Packages#1142 resolves this (I pulled and tried it out locally) and we'll probably see it in the next release.

fluke commented 7 years ago

@tshedor How do I load it from the Github repo? Releases take ages.

tshedor commented 7 years ago

@kartikluke 1) Install the PackageResourceViewer package 2) From the Command Palette, choose "PackageResourceViewer: Open Resource" 3) Choose Ruby 4) Choose Ruby.sublime-syntax 5) Replace your local Ruby.sublime-syntax with the contents of the origin file

That will update Ruby highlighting immediately, no compiling required.

fluke commented 7 years ago

@tshedor Thanks man.