search

slint-ui / slint

Slint is a declarative GUI toolkit to build native user interfaces for Rust, C++, or JavaScript apps.
https://slint.dev
Other
17.7k stars 614 forks source link

Expand-properties #6738

Closed szecket closed 1 week ago

szecket commented 3 weeks ago

converted all property val blocks to widgets for next step and legibility

hunger commented 3 weeks ago

The commit messages are not helpful :-/

I guess it's fine if you squash the commits later: In this case the description of the PR will be used. Otherwise we will have "it hurts" in our history forever -- which does not explain anything about the change that is contained in that patch.

hunger commented 3 weeks ago

Please remove the last change in this set ("It hurts"). It just adds a blank line, that should really not be necessary ;-)

szecket commented 3 weeks ago

Sorry. Literally what hurt was that commit message. I didn’t know how to create a PR other than when pushing so I added a blank line and pushed again…Sent from my iPhoneSent from my iPhoneOn Nov 8, 2024, at 6:43 AM, Tobias Hunger @.***> wrote: @hunger requested changes on this pull request.

In tools/lsp/ui/views/property-view.slint:

NameLabel { property-information: property; element-information: root.element-information; }

Ideally this would not be mixed in between Elements but be at the top of the block with all other properties. Just a nit-pick :-)

In tools/lsp/ui/views/property-view.slint:

@@ -196,7 +196,52 @@ component FloatWidget inherits VerticalLayout { } } } +component StringWidget inherits VerticalLayout {

Can you format this properly? The indentation is off in places.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>