search

slipHQ / run-wasm

Run WASM based code executions in the browser easily
https://www.runwasm.com
Apache License 2.0
468 stars 47 forks source link

Rename the example-nextjs -> website #90

Open jsjoeio opened 2 years ago

jsjoeio commented 2 years ago

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

I think the example-nextjs folder could be named more appropriately.

Describe the solution you'd like A clear and concise description of what you want to happen.

Rename to website

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

N/A

Additional context Add any other context or screenshots about the feature request here.

N/A

Deep-Codes commented 2 years ago

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

I think the example-nextjs folder could be named more appropriately.

Describe the solution you'd like A clear and concise description of what you want to happen.

Rename to website

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

N/A

Additional context Add any other context or screenshots about the feature request here.

N/A

can with-nextjs be a good example?

have seen this pattern in bunch of repos

Screenshot 2021-10-03 at 10 02 43 AM
shadab14meb346 commented 2 years ago

If the suggested approach in the PR subscription looks good then I can go ahead and work on it.

jsjoeio commented 2 years ago

@Deep-Codes Hmm...I mean this folder is specifically for the runwasm website. the "with-nextjs" is a common pattern when you explaining how to use X with Y,Z tools.

I don't think that would fit in this case.

If the suggested approach in the PR subscription looks good then I can go ahead and work on it.

I think we'll need to wait for @kennethcassel to chime in here!

kennethcassel commented 2 years ago

@jsjoeio yeah we should rename it website!

jsjoeio commented 2 years ago

@shadab14meb346 feel free to take this on (or if you don't want to do this, tell me and I will!)

shadab14meb346 commented 2 years ago

Hi @jsjoeio yeah you can go ahead and do it. I see for me a lot of lint issues are coming some how.

jsjoeio commented 2 years ago

Not sure if/when I'll get to this so someone else can hop in if they want :)