search

slovnicki / beamer

A routing package built on top of Router and Navigator's pages API, supporting arbitrary nested navigation, guards and more.
MIT License
591 stars 129 forks source link

Removed transition and reverese transition durations on BeamPage #677

Closed busslina closed 1 month ago

busslina commented 2 months ago

When BeamPage is BeamPageType.noTransition

busslina commented 2 months ago

Seems the test is failing, but not in the code I modified.

Sten435 commented 1 month ago

Seems the test is failing, but not in the code I modified.

This is fixed in PR #674

slovnicki commented 1 month ago

This was also merged in #676 so I don't understand why we have 2 :man_shrugging: anyway, we can close.

busslina commented 1 month ago

This was also merged in #676 so I don't understand why we have 2 🤷‍♂️ anyway, we can close.

It was merged on other branch (v1.6) which I didn't knew if was gonna merge this branch (master).

slovnicki commented 1 month ago

@busslina Ah, sorry, my bad. I will reopen and merge. @Sten435 It should have no conflicts with #674 so all good.