windows meson clang: OVS_REQ_WRLOCK

[williamtu]

"clang" "-Ilib\libopenvswitch.a.p" "-Ilib" "-I..\lib" "-I." "-I.." "-Iinclude\openflow" "-I..\include\openflow" "-Iinclude\openvswitch" "-I..\include\openvswitch" " -I..\include\windows" "-Iinclude" "-I..\include" "-I..\datapath-windows\include" "-IC:\PTHREADS-BUILT\include" "-Xclang" "-fcolor-diagnostics" "-pipe" "-D_FILE_OFFS ET_BITS=64" "-Wall" "-Winvalid-pch" "-g" -MD -MQ lib/libopenvswitch.a.p/dpif-netlink.c.obj -MF "lib\libopenvswitch.a.p\dpif-netlink.c.obj.d" -o lib/libopenvswitch.a .p/dpif-netlink.c.obj "-c" ../lib/dpif-netlink.c In file included from ../lib/dpif-netlink.c:19: In file included from ..\lib/dpif-netlink.h:24: In file included from ..\lib/flow.h:25: In file included from ..\lib/bitmap.h:22: ..\lib/util.h:81:17: warning: unused variable 'addr' [-Wunused-variable] const char addr = (const char )start; ^ In file included from ../lib/dpif-netlink.c:19: In file included from ..\lib/dpif-netlink.h:24: In file included from ..\lib/flow.h:31: In file included from ..\lib/packets.h:32: ..\lib/tun-metadata.h:40:6: warning: forward references to 'enum' types are a Microsoft extension [-Wmicrosoft-enum-forward-reference] enum ofperr tun_metadata_table_mod(struct ofputil_tlv_table_mod , ^ In file included from ../lib/dpif-netlink.c:37: ..\lib/dpif-provider.h:84:6: warning: forward references to 'enum' types are a Microsoft extension [-Wmicrosoft-enum-forward-reference] enum ct_features; ^ In file included from ../lib/dpif-netlink.c:50: ..\lib/odp-util.h:159:6: warning: forward references to 'enum' types are a Microsoft extension [-Wmicrosoft-enum-forward-reference] enum odp_key_fitness odp_tun_key_from_attr(const struct nlattr , ^ ../lib/dpif-netlink.c:470:20: error: use of undeclared identifier 'dpif' OVS_REQ_WRLOCK(dpif->upcall_lock) ^

[williamtu]

need -Wthread-safety

[williamtu]

this is a bug, we should fix or remove OVS_REQ_WRLOCK