smadaminov / ovs-dpdk-meson-issues

VMware Summer 2021
BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

windows meson: struct sigaction will not be visible outside of this function #32

Open williamtu opened 3 years ago

williamtu commented 3 years ago

FAILED: lib/libopenvswitch.a.p/fatal-signal.c.obj "clang" "-Ilib\libopenvswitch.a.p" "-Ilib" "-I..\lib" "-I." "-I.." "-Iinclude\openflow" "-I..\include\openflow" "-Iinclude\openvswitch" "-I..\include\openvsw itch" "-I..\include\windows" "-Iinclude" "-I..\include" "-I..\datapath-windows\include" "-IC:\PTHREADS-BUILT\include" "-Xclang" "-fcolor-diagnostics" "-pipe" "-D_FILE_OFFSET_BITS=64" "-Wall" "-Winvalid-pch" "-g" "-Wthread-safety" "-Wno-microsoft-enum-forward-reference" "-Wno-unused-function" "-Wno-sometimes-unini tialized" "-Wno-format" "-Werror" "-dM" "-U_MSC_VER" "-D_TIMESPEC_DEFINED" "-D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS" "-D_CRT_SECURE_NO_DEPRECAT E" -MD -MQ lib/libopenvswitch.a.p/fatal-signal.c.obj -MF "lib\libopenvswitch.a.p\fatal-signal.c.obj.d" -o lib/libopenvswitch.a.p/fatal-signal.c.obj "-c" ../l ib/fatal-signal.c In file included from ../lib/fatal-signal.c:31: ..\lib/signals.h:27:42: error: declaration of 'struct sigaction' will not be visible outside of this function [-Werror,-Wvisibility] void xsigaction(int signum, const struct sigaction , struct sigaction old);

williamtu commented 3 years ago
diff --git a/lib/signals.h b/lib/signals.h
index 436f934f8..1c110f0d2 100644
--- a/lib/signals.h
+++ b/lib/signals.h
@@ -24,6 +24,7 @@
 enum { SIGNAL_NAME_BUFSIZE = 7 + INT_STRLEN(int) + 1 };
 const char *signal_name(int signum, char *namebuf, size_t bufsize);

+#ifdef LINUX
 void xsigaction(int signum, const struct sigaction *, struct sigaction *old);
-
+#endif
 #endif /* signals.h */