issues
search
smallcloudai
/
refact-chat-js
Shared chat code for all IDEs
BSD 3-Clause "New" or "Revised" License
8
stars
0
forks
source link
Fix: Title generation in background after resuming of chat
#167
Closed
alashchev17
closed
1 month ago
alashchev17
commented
1 month ago
Fix: Title generation in background after resuming of chat
Description
Problem: After resuming of chat with uncalled tools previously, title wasn't generated.
Solution: Additional flag of
isTitleGenerated
and updated logic for title generation
Can't create title in background
Type of change
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactoring (no functional changes, only code improvements)
[ ] Documentation update
How to Test
Step 1: Use CodeLens 'Explain' of 'Find Problems' with
auto_submit
flag set to
true
Step 2: Immediately go to history view page, where all chat threads are located
Step 3: Return to the chat when streaming is done
Step 4: Click on 'Resume' to continue response generation coming from model
Step 5: Go to history view again, wait for the end of streaming
Step 6: If model didn't try to call any tools, title should be generated correctly. If model called tools, go back to step 3
Checklist
[x] My code follows the code style of this project.
[x] I have performed a self-review of my code.
[x] I have commented my code, particularly in hard-to-understand areas.
[ ] I have added tests that prove my fix is effective or that my feature works.
[x] New and existing unit tests pass locally with my changes.
[ ] Any dependent changes have been merged and published in downstream modules.
[ ] I have updated the documentation where necessary.
Fix: Title generation in background after resuming of chat
Description
isTitleGenerated
and updated logic for title generationType of change
How to Test
auto_submit
flag set totrue
Checklist