smallcloudai / refact-chat-js

Shared chat code for all IDEs

BSD 3-Clause "New" or "Revised" License

8 stars 0 forks source link

Fix/paths with spaces #186

Closed MarcMcIntosh closed 3 weeks ago

MarcMcIntosh commented 3 weeks ago

Fix pin paths with spaces

Description

The file path can have a space in it, this would cause file path in the pin message to be cut of early.

There's been an lsp update to fix this here https://github.com/smallcloudai/refact-lsp/pull/414

this has be written to be backward compatible with older messages.

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactoring (no functional changes, only code improvements)
[ ] Documentation update

How to Test

Open an old pin message, it should still look the same,
Create a new pin message, it should work when applying

Screenshots (if applicable)

No viable changes

Checklist

[ ] My code follows the code style of this project.
[ ] I have performed a self-review of my code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] New and existing unit tests pass locally with my changes.
[ ] Any dependent changes have been merged and published in downstream modules.
[ ] I have updated the documentation where necessary.

Linked Issues

relies on https://github.com/smallcloudai/refact-lsp/pull/414

Additional Notes