search

smallrye / smallrye-stork

SmallRye Stork is a service discovery and client side-load balancing framework.
http://smallrye.io/smallrye-stork/
Apache License 2.0
81 stars 23 forks source link

Add clarification about how composite service discovery works. #956

Closed aureamunoz closed 1 month ago

cescoffier commented 1 month ago

In another one.

On Fri 11 Oct 2024 at 15:21, Aurea Muñoz Hernández @.***> wrote:

@.**** commented on this pull request.

In docs/docs/service-discovery/composite.md https://github.com/smallrye/smallrye-stork/pull/956#discussion_r1796950000 :

Remember to define the services that make up your composite service.

+Be aware that Stork doesn't work as a standalone service discovery cluster. +Instead, it processes composite configurations—meaning it handles multiple configurations that may use different service discovery implementation. +For each specific configuration, Stork delegates the service discovery task to the appropriate service discovery provider. +If one of these providers doesn't respond or fails, it affects Stork's ability to resolve that specific configuration, but it doesn't mean Stork itself is faulty;

Yes, we can better manage the error case. Do we do it in this PR? or shall we create an issue and do it in another one?

— Reply to this email directly, view it on GitHub https://github.com/smallrye/smallrye-stork/pull/956#discussion_r1796950000, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADCG7IFX4TTRHVFA6MNHEDZ27GERAVCNFSM6AAAAABPYQGMI2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNRSG44TQMRVG4 . You are receiving this because your review was requested.Message ID: @.***>