search

smanders / externpro

build external projects with cmake
MIT License
13 stars 12 forks source link

patch fails on Windows #298

Closed smanders closed 3 years ago

smanders commented 3 years ago

this bug prevents 21.01 from being a usable release

projects that use the patch executable from externpro (for example: internpro) fail on their patch step

2>Performing patch step for 'raptorq'
2>C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5): error MSB6006: "cmd.exe" exited with code -1073741515.
2>Done building project "raptorq.vcxproj" -- FAILED.

the issue https://github.com/smanders/externpro/issues/295 updated patch to version 2.7.6 on Windows and copied a newly required dll (msys-2.0.dll) to the ${patchbld_DIR}/bin/ directory, (see commit https://github.com/smanders/externpro/commit/a6bc37985893137acc46aa968297fa1f482f62fe) but the dll also needs to be copied to the ${STAGE_DIR}/bin so it's part of the installer and the executable/dll are available to projects (like internpro) that use patch from the externpro install

smanders commented 3 years ago

completed with commit to dev branch referenced above