smanders / externpro

build external projects with cmake
MIT License
13 stars 12 forks source link

eigen library name #372

Closed smanders closed 1 year ago

smanders commented 1 year ago

the eigen library cmake namespace and name is Eigen3::Eigen not Eigen3::eigen this needs to be changed in the generated use script, not that anything I know of is using EIGEN_LIBRARIES... we use the name of the library (Eigen3::Eigen) directly

eigen was recently modified to be built via cmake, instead of just copying the headers (it's a header-only library), in using the upstream project's cmake, I decided not to override the namespace or name of the library (was xpro::eigen before the last externpro release)

smanders commented 1 year ago

completed with commit referenced above