smaranjitghose / DocLense

An open-source document scanner!
https://doclense.vercel.app/
Creative Commons Zero v1.0 Universal
147 stars 130 forks source link

Enhancement: Using Named routes instead of on the fly routes. #244

Closed SapinderSingh closed 3 years ago

SapinderSingh commented 3 years ago

I think we should use named routes instead of on the fly routes. They are easy to manage and maintain. In the drawer, we should replace the pages instead of pop and push, because it makes the transition and animation look really bad.

I want to solve this problem. Please assign me this issue, under GSSOC 21.

anushbhatia commented 3 years ago

can you mention the instances for it?

SapinderSingh commented 3 years ago

@anushbhatia what do you mean by instances ?

anushbhatia commented 3 years ago

where is fly routes being used any example?

SapinderSingh commented 3 years ago

@anushbhatia wherever Navigator.push is used.

SapinderSingh commented 3 years ago

@anushbhatia I think we should use the routes table and Navigator.pushNamed

anushbhatia commented 3 years ago

Be careful to check all navigation routes there

SapinderSingh commented 3 years ago

Be careful to check all navigation routes there

@anushbhatia Okay 👍

SapinderSingh commented 3 years ago

Issue resolved by #248