search

smart-data-models / dataModel.Transportation

Transportation Data Model
37 stars 35 forks source link

CityWork model.yaml misses "Geoproperty" type in x-ngsi #19

Closed isalvadori closed 2 years ago

isalvadori commented 2 years ago

Hi, in the geo-properties defined in the CityWork model.yaml (lineLocation in busImpacted for example) a x-ngsi type information, which indicates they are a geo property is missing. Would it be possible to add it? In other model this is always present when we are dealing with GeoJSON, and it's helpful to quickly extract information about the model structure.

Thanks!

albertoabellagarcia commented 2 years ago

There are several points here. On one hand, there were poorly defined descriptions. Now we have changed them and republished identifying properly what attributes were geoproperties. In some minutes it is fixed and available. But, if what you need is the x-ngsi type for subattributes. this is something that we have not currently implemented. It is on the queue anyway but there is not a clear schedule for it. Is the correction good enough or do you need the NGSI type for subattributes? the link to the script generating the model.yaml is here https://github.com/smart-data-models/data-models/blob/master/utils/10_model.yaml_v10.py

isalvadori commented 2 years ago

Thanks! I think I can make it work also looking at the description to discriminate what is a geoproperty and what is not. But it would be nice to have in the future also the NGSI type for subattributes, indeed.

Thanks again!