Closed jmarrero closed 7 months ago
@jmarrero We'll also want to teach them how to initialize their git repo before they push:
cd ~/smartvillage-service/
git init
git add README.md
git commit -m "first commit"
git branch -M main
git remote add origin https://github.com/.../smartvillage-service.git
git push -u origin main
@jmarrero And we can show them a .gitignore that will ignore annoying Python jupyter notebook backup files:
**/.ipynb_checkpoints
@jmarrero we also have the option of building the image directly with a GitHub action to GitHub's container registry and use an image like ghcr.io/computate/smartvillage-service:main
. This means we can skip quay.io completely. I'm curious what you think here.
@jmarrero we also have the option of building the image directly with a GitHub action to GitHub's container registry and use an image like
ghcr.io/computate/smartvillage-service:main
. This means we can skip quay.io completely. I'm curious what you think here.
I understand there is no need to use quay or build it using extra steps. Importing the repo into openshift builds it for us. I am not sure why we want them to also push it to a repository if openshift is going to push it to the internal one.
@jmarrero we also have the option of building the image directly with a GitHub action to GitHub's container registry and use an image like
ghcr.io/computate/smartvillage-service:main
. This means we can skip quay.io completely. I'm curious what you think here.
This is really easy to do yeah. I got a couple of example I use myself that I can adapt for this. https://github.com/jmarrero/silverblue-setup/blob/main/.github/workflows/build.yml
This one uses the buildah github action, so we can still keep it using our tech.
@computate ready for review, now I will do a followup PR for the images. But I think the instructions are complete now.
This add the python microservice notebook. Still a work in progress as I need to add the steps for deploying into OpenShift and clear instructions on how to update workbench.