search

smartdevicelink / sdl_core

SmartDeviceLink In-Vehicle Software and Sample HMI
BSD 3-Clause "New" or "Revised" License
242 stars 244 forks source link

Fix RequestControllerTest.CheckPosibilitytoAdd_ZeroValueLimiters_SUCCESS #3947

Closed jacobkeeler closed 2 years ago

jacobkeeler commented 2 years ago

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

Run request_controller_test repeatedly (around 100 times), verify that tests never fail

Summary

Add TestAsyncWaiter to handle asynchronous expectations in RequestControllerTest.CheckPosibilitytoAdd_ZeroValueLimiters_SUCCESS

Changelog

Bug Fixes

CLA

ShobhitAd commented 2 years ago

Similar unit test failing

[ RUN      ] RequestControllerTestClass.AddMobileRequest_SetValidData_SUCCESS
/home/user/sdl/CORE/release/sdl_core/src/components/application_manager/test/request_controller/request_controller_test.cc:259: Failure
Actual function call count doesn't match EXPECT_CALL(app_mngr_, IsStopping())...
         Expected: to be called once
           Actual: never called - unsatisfied and active
pure virtual method called
terminate called without an active exception
Aborted (core dumped)

Might have to apply the TestAsyncWaiter changes to other similar tests