joeljfischer commented 1 year ago

Fixes #2109

Risk

This PR makes no API changes.

Testing Plan

[x] I have verified that I have not introduced new warnings in this PR (or explain why below)
[x] I have run the unit tests with this PR
[x] I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).

Unit Tests

Updated the present alert operation tests to handle the new checks.

Core Tests

Uploaded an image with a particular name, then tried to present an alert with a new overwriting image with the same name.

sdl_ios-9-18-01-AM.patch.zip

Core version / branch / commit hash / module tested against: Manticore (Core v8.1) HMI name / version / branch / commit hash / module tested against: Manticore (Generic_HMI v0.12.0

Summary

This PR changes some logic around how the present alert operation handles showing the alert icon image to fix an issue with showing overwriting images.

Changelog

Bug Fixes

Fixes screen manager present alert not showing the icon if it was marked to overwrite another.

CLA

[x] I have signed the CLA

codecov[bot] commented 1 year ago

Codecov Report

Merging #2110 (58cd0a0) into develop (9aec1f6) will increase coverage by 0.11%. The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #2110      +/-   ##
===========================================
+ Coverage    85.45%   85.57%   +0.11%     
===========================================
  Files          448      448              
  Lines        22795    22988     +193     
===========================================
+ Hits         19480    19672     +192     
- Misses        3315     3316       +1