smartprocure / futil-js

F(unctional) util(ities). Resistance is futile.
https://smartprocure.github.io/futil-js/
MIT License
967 stars 68 forks source link

Do not remove zeroes from tree paths #438

Closed stellarhoof closed 4 months ago

stellarhoof commented 4 months ago

Use an internal only function for now and add comments on the other functions to remember to change in the next major.

changeset-bot[bot] commented 4 months ago

🦋 Changeset detected

Latest commit: 7ba3a58679ec01696def0ef0196a0917efd3c9d7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ----- | ----- | | futil | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 4 months ago
Fails
:no_entry_sign: Danger failed to run `/home/runner/work/futil-js/futil-js/node_modules/duti/src/dangerfile.js`.

Error Error

Cannot find module 'futil'
Require stack:
- /home/runner/work/futil-js/futil-js/node_modules/duti/src/duties/pr.js
- /home/runner/work/futil-js/futil-js/node_modules/duti/src/duties/index.js
- /home/runner/work/futil-js/futil-js/node_modules/duti/src/dangerfile.js
- /home/runner/work/futil-js/futil-js/node_modules/danger/distribution/runner/runners/inline.js
- /home/runner/work/futil-js/futil-js/node_modules/danger/distribution/commands/danger-runner.js
Error: Cannot find module 'futil'
Require stack:
- /home/runner/work/futil-js/futil-js/node_modules/duti/src/duties/pr.js
- /home/runner/work/futil-js/futil-js/node_modules/duti/src/duties/index.js
- /home/runner/work/futil-js/futil-js/node_modules/duti/src/dangerfile.js
- /home/runner/work/futil-js/futil-js/node_modules/danger/distribution/runner/runners/inline.js
- /home/runner/work/futil-js/futil-js/node_modules/danger/distribution/commands/danger-runner.js
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:1028:15)
    at Function.Module._load (node:internal/modules/cjs/loader:873:27)
    at Function._module2.default._load (/home/runner/work/futil-js/futil-js/node_modules/override-require/dist/overrideRequire.js:43:25)
    at Module.require (node:internal/modules/cjs/loader:1100:19)
    at require (node:internal/modules/cjs/helpers:119:18)
    at Object.<anonymous> (/home/runner/work/futil-js/futil-js/node_modules/duti/src/duties/pr.js:2:9)
    at Module._compile (node:internal/modules/cjs/loader:1198:14)
    at Object.customModuleHandler (/home/runner/work/futil-js/futil-js/node_modules/danger/distribution/runner/runners/inline.js:129:28)
    at Module.load (node:internal/modules/cjs/loader:1076:32)
    at Function.Module._load (node:internal/modules/cjs/loader:911:12)
    at Function._module2.default._load (/home/runner/work/futil-js/futil-js/node_modules/override-require/dist/overrideRequire.js:43:25)
    at Module.require (node:internal/modules/cjs/loader:1100:19)
    at require (node:internal/modules/cjs/helpers:119:18)
    at Object.<anonymous> (/home/runner/work/futil-js/futil-js/node_modules/duti/src/duties/index.js:1:10)
    at Module._compile (node:internal/modules/cjs/loader:1198:14)
    at Object.customModuleHandler (/home/runner/work/futil-js/futil-js/node_modules/danger/distribution/runner/runners/inline.js:129:28)

Dangerfile

-------------------^

Generated by :no_entry_sign: dangerJS against 7ba3a58679ec01696def0ef0196a0917efd3c9d7

github-actions[bot] commented 4 months ago

Coverage after merging feature/fix-tree-paths into master will be

83.95%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
.yarn/releases
   yarn-3.6.0.cjs11.87%9.15%19.16%50.14%10, 10, 10, 10, 10, 10, 100–101, 101, 101, 103, 103, 103, 103, 103, 103, 103, 103, 106–107, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 111, 111, 111, 115, 115, 115, 117–118, 118, 118–119, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 120, 122, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127, 127,